Skip to content

feat(games): add 2048 deployment with README - #156

Merged
peucastro merged 3 commits into
mainfrom
feat/games-2048
Oct 20, 2026
Merged

peucastro merged 3 commits into
mainfrom
feat/games-2048

Conversation

@FrozenHart

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unresolved routing, reproducibility, deployment error handling, and documentation issues remain.

5 open issues
What changed in this PR

Adds Kubernetes resources and deployment tooling for the 2048 game.

Changes:

  • Adds namespace, Deployment, and ClusterIP Service manifests.
  • Configures Traefik routing for 2048.localhost.
  • Adds a deployment script; the advertised README is missing.
File Summary
services/​games/​2048/​deploy.sh Applies the manifests, but needs fail-fast handling and the promised README.
services/​games/​2048/​02-ingress-route.yaml Configures external routing, but HTTPS and hostname mapping need correction.
services/​games/​2048/​01-deployment.yaml Defines the game Deployment and Service; the image should be immutable.
services/​games/​2048/​00-namespace.yaml Defines the dedicated game namespace.

Review effort: Lite

Comment thread services/games/2048/01-deployment.yaml Resolved
Comment thread services/games/2048/deploy.sh Resolved
Comment thread services/games/2048/deploy.sh Resolved
@FrozenHart
FrozenHart requested a review from peucastro October 20, 2026 10:18
@peucastro
peucastro merged commit 0bc8a02 into main Oct 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deployment Tutorial using values.yaml and our organization

4 participants